Add assert_not_both_not_none (fixes #393)#421
Open
Sorata-kanda wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Add assert_not_both_not_none (fixes #393)#421Sorata-kanda wants to merge 1 commit intogoogle-deepmind:mainfrom
Sorata-kanda wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have signed the CLA. |
Sorata-kanda
force-pushed
the
add_not_both_none_assert
branch
from
2388356 to
7cee800
Compare
Sorata-kanda
force-pushed
the
add_not_both_none_assert
branch
from
7cee800 to
0155790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new static assertion
assert_not_both_not_nonerequested in issue #393.Behavior validation:
Implemented in asserts.py and validated via existing assertion tests.
All local tests pass aside from an unrelated chexify docstring issue which occurs on main as well.